Move FD_SETSIZE to configure.ac #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit from the pull request riscv-collab#644 sets the macro FD_SETSIZE to 128 for every host OS, while it is needed on Windows only. Note that this macro has a much higher value on other OS and after this commit it get reduced to 128 only. Since in configure.ac is already present a hook to change the compile defines for Windows, move there also FD_SETSIZE. Signed-off-by: Antonio Borneo <[email protected]>
en-sc
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Thanks for the patch! LGTM.
@JanMatCodasip, @MarekVCodasip, please take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit from the pull request #644 sets the macro FD_SETSIZE to 128 for every host OS, while it is needed on Windows only. Note that this macro has a much higher value on other OS and after this commit it get reduced to 128 only.
Since in configure.ac is already present a hook to change the compile defines for Windows, move there also FD_SETSIZE.
I have pushed in upstream OpenOCD the patch https://review.openocd.org/c/openocd/+/8503 that, together with this pull request, aligns the two repositories on this topic.
I will wait for review and eventual merge of this pull request before merging the corresponding patch upstream. Of course, the review process is open upstream too.
Hope this helps the sync between the two repositories.